I have a few criteria I look at when I evaluate ranges. In rough order of importance:
1) Multiple teeing grounds which allow the player to hit in various directions - I find that hitting balls downwind tends to straighten out my ball flight. I prefer to hit into the wind because it accentuates mishits.
Honorable mention: Sea Island, Pine Valley, PGA Village, Hidden Creek, TPC Sawgrass, Bandon Dunes, Rich Harvest
Dishonorable mention: Garden City GC
2) Practice tee manicured as close to fairway conditions and as flat as possible - It is important to have quality turf to hit from. Practicing on a tee which gives you flyer lies or (gasp!) mats only can mess up your concept of yardages and contact.
Honorable mention: The Hideout, Pine Valley, Butler National, Victoria National
Dishonorable mention: Bethpage, Navy
3) Numerous target greens with varying distances and directions - Should go up to at least 230-250 yards. Bonus points if there are several targets within 100 yards or a warm up/wedge range which allows the player the chance to work on shots inside 150 or so.
Honorable mention: Pine Valley, Philadelphia Cricket Club, ACE Club, Oakmont
Dishonorable mention: Monroe
4) Slightly elevated tee to allow the player to see his shots land but not so much so that it effects depth perception and distance judgment.
Honorable mention: Aronimink, Philadelphia Cricket, Sunnybrook
Dishonorable mention: Baltusrol, Huntingdon Valley, Oakmont, Lake Jovita
5) Large enough to accommodate any club in the bag from any player
Honorable mention: Pine Valley, Hidden Creek, Philadelphia Cricket Club, Butler National, Victoria National, Old Memorial
Dishonorable mention: Garden City GC, Philadelphia Country Club, Merion
6) Balls - I don't expect Pro V1s, but at least give me something I can somewhat rely on for accurate distance!
Honorable mention: Adios, ACE Club
Dishonorable mention: Bethpage
This is before considering short game areas and practice greens. In my opinion an ideal practice green would contain a flatter section enabling the player to work on feel and distance control while there would also be a section with undulations to practice any severity of break desired.
Honorable mention: Aronimink, Beverly CC, Oakmont, Philadelphia Country Club, Bethpage
Dishonorable mention: Bandon Dunes, Chambers Bay (though granted, both courses do not have any flat spots on their actual greens, so why have any on the practice green)
Short game area - should have the ability to replicate any shot which could be encountered within 60 yds of the hole.
Honorable mention: White Manor, Beverly, Victoria National, Pine Valley, Bandon, Cherry Hills, Black Sheep, Rich Harvest
Dishonorable mention: Innisbrook, Wolf Run