I think, outside of the clubs where money is still not an issue, the role of the club professional is a shell of what it used to be, based on many factors already discussed on this forum.
I grew up in the 90's working as a caddie and back-room worker. It was my only job for almost a decade, and the local clubs all had your traditional system: older head professional with a couple of young assistants. In almost every situation, the following were characteristics you would see in almost every case:
1) The pro owned the shop and the merchandise (a lot of work, but a huge salary boost)
2) All the professionals could play AND teach
3) The members could ask the professionals any advice golf related
I went to college, and came out looking for a job and entered the business as an assistant (back in 2003) and the world of the club pro had already changed and continues to. With the almighty dollar influencing so many decisions, sacrifices have been made. More and more "professionals" in the shop are double-digit handicappers, and not who you want playing with the members. The merchandise has been taken away. At public courses, you sometimes see only a person running the register, probably for close to minimum wage.
And, contrary to some points on here, the bargain superstores have hurt business. I was an assistant at a club with a $40,000 initiation fee, and always heard gripes from the members that we charged $44 a dozen for Pro-V1 balls when they could get them for $40 at Dicks.
I think a lot of it has to do with the type of member some of these clubs are seeing. The technology boom brought a lot of money to people who did not grow up in the traditional club mentality. They can afford to join high-end clubs, but have no perspective on what the professional can be.
I still think the golf business is one of the best jobs out there, but the good opportunities are disappearing quickly. I only lasted 2 years before I had to make a better decision for my family, and I don't encourage many younger guys to explore the business.