"Is there a coralation between the progress of architecture within a nation and the champions they produce?"
I doubt there's any correlation if one is talking about world class touring professional champions. Just looking at say the top ten players in the world right now would seem to prove that out. How many great courses are there in Fiji, for instance?
What Rich Goodale and someone else above said is probably true of world class champions---eg they are very adaptable to courses anywhere and I can't see how that would correlate to the architecture of their nation. The only exception to that I can think of was probably Trevino and his refusal to play the Masters because he convinced himself the course just didn't suit his game (Nicklaus actually mentioned he thought Trevino's aversion to ANGC was nuts and Jack said Trevino probably could've found a way to win there if he hadn't done such a good job of talking himself out of it).
But in a good amateur sense there may be something to good architecture=good players. In the Philadelphia district, at least, that theory was very definitely on George Crump's mind when he built PVGC. One of his distinct goals was to raise the level of tournament players from the region in regional and national championships by distinctly raising the level of a "championship test" with PVGC. (There was even a significant early member of PVGC who promiised to contribute X dollars to PVGC depending on the players from this district making the US Amateur!).
In recent years I've heard Gordon Brewer, the current president of PVGC, say in public on many occasions that the quality of golf architecture in the Philadelphia region has been directly responsible for the high level of amateur champions coming out of this region. Brewer, himself had a good career nationally winning two national championship and coming very close in another. I don't know if what he said about that is provable historically but I do know Philadelphia did produce some notable champions including J.J Mcdermott, Max Marston, Bill Hyndman, of course the incomparable modern amateur Jay Sigel and on the women's side perhaps the most successful American women's amateur Glenna Collett Vare (six US Amateur championships!). On the other side of the state, Pittsburgh, which has a number of excellent courses there is the all time energizer bunny, my old friend Carol Semple Thompson whose national championship production is somewhere around Woods, Nicklaus and Bobby Jones. Thompson has also won 20 state amateur championships! That's right, it's not a typo, that's 20 state amateur championships, and PA is no small state golf-wise.
We've felt relatively recently that some of the best players from this district come from HVGC simply because that course has so many unlevel lies and consequently HVGC players have become better ball strikers for it. But I think the real reason some clubs and even some districts produce good players has more to do with some type of synergistic golf culture within various golf clubs or even districts---eg they tend to inspire each other to do better. Hence clubs around here like Overbrook, PCC, Llanerch, even little Yardley and now Tavistock.
Tom MacWood:
I wonder where you came up with this thread's question. Have you been reading "Greens and Greenkeeping" recently because in it I believe Harold Hilton ruminated on this very subject of architecture and good players vis-a-vis the differing games of early British Isles top players depending on which course they came from. In it he said some got so used to pitching the ball they weren't good at the low run-in shot and vice versa for those from TOC I believe.