Many architects would say the ideal Tour Pro to work with is one who takes his money and doesn't show up to gum up the works, which is about what happens in most cases.
I have had the pleasure to work with many who actually did contribute, and not being a great player myself, believe they helped my design philosophy along. The best for me, IMHO, were the grinders like Larry Nelson, Jim Colbert, and Notah Begay. Unlike Nicklaus, who overpowered with a high fade, or others who always hit a draw (actually, Larry fit this mold) these guys tried to manufacture shots to maximize their chance for success, to overcome their physical flaws. So, it gave me insight as to how to set up certain shots they would find challenging and appealing. (Yes, I know some here would go out of their ways to set up unappealing shots, but really, read Mac if you think this is a good idea)
BTW, among top golfers, they called Faldo the one who worked on all the shots more than others, and he would be a good choice to learn from, IMHO.