Justin,
To be honest with you, 99% of Americans don't even know that Jack Nicklaus is now an architect. Aside from RTJ and maybe Pete Dye, I don't know if any architect has ever been a publicly renowned personality. Dye was made famous by the AM/EX commercials. There's a quote in Jurassic Park that equates RTJ to some other famous person in their field, so he was possibly a well-known personality. Perhaps some of the more prominent personalities of the Golden Age were household names. People like Thomas and Hunter could have been because they had other interests besides just GCA. But for architecture if any did, I would bet Mackenzie, Ross, Macdonald and maybe Tillinghast could have been somewhat familiar names to the general populus.
I don't know enough details of Tillinghast, but from the biography done by Tom Doak, etal it seems that Mackenzie led a fast life. But I doubt that many of the architects today live the "easy" life. In talking with people like Jerry Slack, Jerry Lemons, Mike DeVries and others, I doubt they are running with high rollers. They probably more than likely have good lives and can buy their groceries on a weekly basis without much thought. The select few that are at the top of the profession may, but just like everything else those are not the rule of thumb to go by.
In researching his life, I have found that Perry Maxwell is often seen, incorrectly, as a rich banker who had money out the wazzoo. Perry wasn't hurting for money, but he was not the type of guy who would have lived that way, even if he had the ability. He kept cash flowing to pay for his kids college and to live his life without really touching his nestegg. In comparison to many people during the Depression, I suppose you could call him "rich" for the purposes of this post.