Mike
My reading of the situation, based on talking to a lot of China experts, is that golf is not itself in the firing line especially, but that it is caught in a pretty severe crossfire.
It's well known that President Xi's big priority is to crack down on corruption within the Party; well, unfortunately, golf has been the venue, if you like, for a lot of that corruption. That is the root cause of the ban on Party members becoming members of golf clubs.
Arable land is precious in China; yes it's a huge country, but it has an even huger population, and memories of food shortages are strong. So anything that takes away farmland is likely to be controversial; and anyone who followed the days of major golf development in China cannot be unaware that lots of farmers were removed from their land to allow for the development of golf estates. This was always ethically problematic, even if they were compensated; once central government got involved the results are hardly surprising.
Finally there is the battle for power between central government and Party cadres in the regions. A cynical, but probably honest, golf architect once told me 'The difference between developing golf in China and India is that in China you only have to bribe one guy; in India you might have to bribe a thousand.' This is because in China, the government controls all the land. That's how so much golf got to be built; the local and regional government operatives looked the other way when golf courses were described in planning documents as public parks and so on, presumably because the developers had made it worth their while. Which brings us back to President Xi and his anti-corruption drive...