Nice references above to East Lake and Savannah. Congressional CC was in part taken over by the OSS during WWII and used for ammunition testing. Whistling Straits-Straits Course and irish Course occupy land that had previously been used for army artillery testing and airplane landings. The greatest bunker of any US golf resort, at The Greenbrier, was built as a refuge for Congress in case of nuclear attack. Los Alamos Municipal GC was built as part of the effort in that remote New Mexico town to give nuclear scientists some recreation and to keep from going crazy
I think it was Dick Wilson who spent WWI designing air fields for the U.S. military.
And how could anyone overlook the crucial role Alistair MacKenzie played in WWI trench warfare, as well as in camouflage. He wrote several essays about it in military journals, including two posthumously published pieces in "The Military Engineer" that appeared in 1934. Sorry for any factual mistakes as I am in a hotel room and unable to reference my own materials so am writing off the top of my head.
By the way, golf was originally banned in St. Andrews because the king thought that locals were squandering their skills and time when they should have been practising archery and other coastal defenses against invaders.
The most copied hole in the world, the Redan at North Berwick, was so named by soldiers returning from the Crimean War because it evoked an impregnable fortress in Sevastapol.