Pat,
If by golfers you mean people who post on GCA, then the answer gets a bit more involved.
If by golfers you mean the general golfing public... then basically a well kept place to chase a ball around for a few hours.
Personally, I am looking for a little bit of adventure. I like being taken places while playing golf and I find the little nuances and subtle features will keep me coming back trying to find new ways of attacking a hole, or, new ways of getting to the same place (in continuing with my adventure comment). I love routings and holes that wind through the land taking me past places of interest. I love little features like quarries, quirky turns in the routing. Holes that require staircases or really narrow paths (big enough for a golfer and carry bag and not a cart) to get in and out of some of the features, or between holes. I like dramatic use of elevation, either up and down, oblique, or switch-backed.
I like holes that deceive me visually and surprise me or make me chuckle at my own ignorance after I've played it. Holes that make me realize while I'm playing them for the first time that I was very close to being in a lot of trouble, or holes that I can figure out every once and awhile from the tee.
Those are just my thoughts though, and unfortunately, the cynic in me believes my first answer is a more accurate representation of most golfers.